From 13e12f7ccf9e58093c645ce128566e70375bb9d5 Mon Sep 17 00:00:00 2001
From: Valentin Kaelin <kalanehd@gmail.com>
Date: Thu, 13 Feb 2020 20:42:13 +0100
Subject: [PATCH] refactor: make SwitchToggle component reusable

---
 client/src/components/Form/SwitchToggle.vue   | 31 +++++++++++--------
 client/src/components/Match/DetailedMatch.vue | 17 ++++++++--
 2 files changed, 32 insertions(+), 16 deletions(-)

diff --git a/client/src/components/Form/SwitchToggle.vue b/client/src/components/Form/SwitchToggle.vue
index f606ff1..1389992 100644
--- a/client/src/components/Form/SwitchToggle.vue
+++ b/client/src/components/Form/SwitchToggle.vue
@@ -11,7 +11,7 @@
       :class="{'selected-label': selected}"
       for="toggle-on"
       class="inline-block py-1 rounded-l-full border-t-2 border-r border-b-2 border-l-2 border-teal-500 cursor-pointer"
-    >%</label>
+    >{{ leftLabel }}</label>
     <input
       v-model="selected"
       id="toggle-off"
@@ -23,7 +23,7 @@
       :class="{'selected-label': !selected}"
       for="toggle-off"
       class="inline-block py-1 rounded-r-full border-t-2 border-r-2 border-b-2 border-l border-teal-500 cursor-pointer"
-    >Total</label>
+    >{{ rightLabel }}</label>
     <div
       :class="selected ? 'left-checked' : 'right-checked'"
       class="selector absolute w-1/2 inset-0 bg-teal-500"
@@ -32,26 +32,31 @@
 </template>
 
 <script>
-import { mapActions, mapState } from 'vuex'
-
 export default {
+  props: {
+    leftLabel: {
+      type: String,
+      required: true,
+    },
+    rightLabel: {
+      type: String,
+      required: true,
+    },
+    value: {
+      type: Boolean,
+      required: true,
+    }
+  },
   computed: {
     selected: {
       get() {
-        return this.percentSettings
+        return this.value
       },
       set(value) {
-        this.updatePercent(value)
+        this.$emit('updateValue', value)
       }
     },
-    ...mapState({
-      percentSettings: state => state.settings.percent
-    }),
   },
-
-  methods: {
-    ...mapActions('settings', ['updatePercent']),
-  }
 }
 </script>
 
diff --git a/client/src/components/Match/DetailedMatch.vue b/client/src/components/Match/DetailedMatch.vue
index 5d804ed..c690f80 100644
--- a/client/src/components/Match/DetailedMatch.vue
+++ b/client/src/components/Match/DetailedMatch.vue
@@ -9,7 +9,13 @@
 
       <div class="px-3 py-2 flex justify-between items-start">
         <DetailedMatchGlobalStats :team="allyTeam" :ally-team="true" />
-        <SwitchToggle class="mt-2"></SwitchToggle>
+        <SwitchToggle
+          @updateValue="updatePercent"
+          left-label="%"
+          right-label="Total"
+          :value="percentSettings"
+          class="mt-2"
+        ></SwitchToggle>
         <DetailedMatchGlobalStats :team="enemyTeam" :ally-team="false" />
       </div>
 
@@ -26,7 +32,7 @@
 </template>
 
 <script>
-import { mapState } from 'vuex'
+import { mapActions, mapState } from 'vuex'
 import DetailedMatchGlobalStats from '@/components/Match/DetailedMatchGlobalStats.vue'
 import DetailedMatchTeam from '@/components/Match/DetailedMatchTeam.vue'
 import SwitchToggle from '@/components/Form/SwitchToggle.vue'
@@ -56,8 +62,13 @@ export default {
       return this.data.blueTeam.players.some(p => p.summonerId === this.account.id) ? this.data.redTeam : this.data.blueTeam
     },
     ...mapState({
-      account: state => state.summoner.basic.account
+      account: state => state.summoner.basic.account,
+      percentSettings: state => state.settings.percent
     }),
+  },
+
+  methods: {
+    ...mapActions('settings', ['updatePercent']),
   }
 }
 </script>