From 326647256861b6a48258d49794ccc6e504ed1204 Mon Sep 17 00:00:00 2001
From: Valentin Kaelin <kalanehd@gmail.com>
Date: Sun, 4 Oct 2020 22:05:16 +0200
Subject: [PATCH] feat: start to type Jax response

---
 .../Jax/src/Endpoints/LeagueEndpoint.ts       | 26 ++++++++++++++++++-
 .../Jax/src/Endpoints/SpectatorEndpoint.ts    |  2 +-
 .../Jax/src/Endpoints/SummonerEndpoint.ts     | 13 +++++++++-
 3 files changed, 38 insertions(+), 3 deletions(-)

diff --git a/server-new/app/Services/Jax/src/Endpoints/LeagueEndpoint.ts b/server-new/app/Services/Jax/src/Endpoints/LeagueEndpoint.ts
index be4ec7c..5a71bb6 100644
--- a/server-new/app/Services/Jax/src/Endpoints/LeagueEndpoint.ts
+++ b/server-new/app/Services/Jax/src/Endpoints/LeagueEndpoint.ts
@@ -2,6 +2,30 @@ import { RiotRateLimiter } from '@fightmegg/riot-rate-limiter'
 import { JaxConfig } from '../../JaxConfig'
 import JaxRequest from '../JaxRequest'
 
+export interface LeagueEntryDTO {
+  leagueId: string;
+  queueType: string;
+  tier: string;
+  rank: string;
+  summonerId: string;
+  summonerName: string;
+  leaguePoints: number;
+  wins: number;
+  losses: number;
+  veteran: boolean;
+  inactive: boolean;
+  freshBlood: boolean;
+  hotStreak: boolean;
+  miniSeries?: MiniSeriesDTO
+}
+
+interface MiniSeriesDTO {
+  losses: number,
+  progress: string,
+  target: number,
+  wins: number
+}
+
 export default class LeagueEndpoint {
   private config: JaxConfig
   private limiter: RiotRateLimiter
@@ -11,7 +35,7 @@ export default class LeagueEndpoint {
     this.limiter = limiter
   }
 
-  public summonerID (summonerID:number, region: string) {
+  public summonerID (summonerID: string, region: string): Promise<LeagueEntryDTO[]> {
     return new JaxRequest(
       region,
       this.config,
diff --git a/server-new/app/Services/Jax/src/Endpoints/SpectatorEndpoint.ts b/server-new/app/Services/Jax/src/Endpoints/SpectatorEndpoint.ts
index e2a9b01..f187e70 100644
--- a/server-new/app/Services/Jax/src/Endpoints/SpectatorEndpoint.ts
+++ b/server-new/app/Services/Jax/src/Endpoints/SpectatorEndpoint.ts
@@ -11,7 +11,7 @@ export default class SpectatorEndpoint {
     this.limiter = limiter
   }
 
-  public summonerID (summonerID: number, region: string) {
+  public summonerID (summonerID: string, region: string) {
     return new JaxRequest(
       region,
       this.config,
diff --git a/server-new/app/Services/Jax/src/Endpoints/SummonerEndpoint.ts b/server-new/app/Services/Jax/src/Endpoints/SummonerEndpoint.ts
index d7950db..e10655f 100644
--- a/server-new/app/Services/Jax/src/Endpoints/SummonerEndpoint.ts
+++ b/server-new/app/Services/Jax/src/Endpoints/SummonerEndpoint.ts
@@ -2,6 +2,17 @@ import { RiotRateLimiter } from '@fightmegg/riot-rate-limiter'
 import { JaxConfig } from '../../JaxConfig'
 import JaxRequest from '../JaxRequest'
 
+export interface SummonerDTO {
+  accountId:	string,
+  profileIconId: number,
+  revisionDate:	number,
+  name:	string,
+  id:	string,
+  puuid:	string,
+  summonerLevel:	number,
+  region?: string
+}
+
 export default class SummonerEndpoint {
   private config: JaxConfig
   private limiter: RiotRateLimiter
@@ -11,7 +22,7 @@ export default class SummonerEndpoint {
     this.limiter = limiter
   }
 
-  public summonerName (summonerName: string, region: string) {
+  public summonerName (summonerName: string, region: string): Promise<SummonerDTO> {
     return new JaxRequest(
       region,
       this.config,