Doble/LeagueStats
1
0
Fork 0
mirror of https://github.com/vkaelin/LeagueStats.git synced 2026-03-25 12:57:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: watch vue router changes with $route

Browse source
This commit is contained in:
Valentin Kaelin 2020-02-14 19:34:11 +01:00
parent d77ade8156
commit 594c45f519
1 changed files with 4 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
client/src/layouts/Default.vue
View file

@ -107,8 +107,8 @@
</template>
</div>
</template>
<!-- View -->
<!-- View -->
<transition :name="tabTransition">
<slot></slot>
</transition>
@ -150,15 +150,6 @@ export default {
},
computed: {
summoner() {
return this.$route.params.name
},
region() {
return this.$route.params.region
},
uri() {
return `${this.summoner}|${this.region}`
},
tabTransition() {
return this.summonerFound && this.overviewLoaded ? 'tab' : 'none'
},
@ -169,21 +160,19 @@ export default {
},
watch: {
uri() {
console.log('route changed')
this.updateSettings({ name: 'region', value: this.region.toLowerCase() })
$route() {
this.apiCall()
}
},
created() {
this.updateSettings({ name: 'region', value: this.region.toLowerCase() })
this.apiCall()
},
methods: {
apiCall() {
this.basicRequest({ summoner: this.summoner, region: this.region })
this.updateSettings({ name: 'region', value: this.$route.params.region.toLowerCase() })
this.basicRequest({ summoner: this.$route.params.name, region: this.$route.params.region })
},
isRouteActive(currentRoute) {
return {