Closes #80 - "Update Search Functionality to Accommodate Riot IDs".

- Check in SummonersController per @vkaelin's comment on issue #80
- - Had to send an additional request to get account id after retrieving puuid by gameName/tagline
- `puuidFromRiotTag(name, tagline, string, region)` in SummonerEndpoint
- `summonerPuuid(puuid, region)` in SummonerEndpoint
- Modified `JaxRequest` constructor to take default parameter `riotApiPath`.
- - This is due to `JaxRequest` previously assuming the api subpath of `/lol/`. `AccountsV1` is located at `/riot/`.
- Adjusted `SummonerBasicValidator` schema to accept `-` in input.
This commit is contained in:
zkxjzmswkwl 2024-01-09 05:25:18 -07:00
parent 239f9a8a91
commit bf29894b0c
5 changed files with 61 additions and 4 deletions

View file

@ -35,7 +35,31 @@ export default class SummonersController {
const { summoner, region } = await request.validate(SummonerBasicValidator)
try {
const account = await SummonerService.getAccount(summoner, region)
// Coming from C++ this seems completely fine. Which suggests to me that it likely isn't.
var account
// Checks if searching for Riot tag. Frontend is currently replacing `#` with `-`.
if (!summoner.includes(`-`)) {
account = await SummonerService.getAccount(summoner, region)
} else {
const [name, tagline] = summoner.split(`-`)
account = await SummonerService.getRiotAccountByName(name, tagline, region)
if (!account) {
return response.json(null)
}
const additionalInfo = await SummonerService.getSummonerByPuuid(account.puuid, region)
if (!additionalInfo) {
return response.json(null)
}
account = {
...account,
...additionalInfo,
}
}
// Check if the summoner is found
if (!account) {
return response.json(null)

View file

@ -2,6 +2,7 @@
import RiotRateLimiter from 'riot-ratelimiter'
import { JaxConfig } from '../../JaxConfig'
import JaxRequest from '../JaxRequest'
import { getRiotRegion } from 'App/helpers'
export interface SummonerDTO {
accountId: string
@ -51,4 +52,25 @@ export default class SummonerEndpoint {
36000
).execute()
}
public puuidFromRiotTag(name: string, tagline: string, region: string): Promise<SummonerDTO> {
return new JaxRequest(
getRiotRegion(region),
this.config,
`account/v1/accounts/by-riot-id/${name}/${tagline}`,
this.limiter,
36000,
`riot`
).execute()
}
public summonerPuuid(puuid: string, region: string): Promise<SummonerDTO> {
return new JaxRequest(
region,
this.config,
`summoner/v4/summoners/by-puuid/${puuid}`,
this.limiter,
36000
).execute()
}
}

View file

@ -12,6 +12,7 @@ export default class JaxRequest {
private limiter: RiotRateLimiter
private cacheTime: number
private retries: number
private riotApiPath: string
private sleep: { (ms: number): Promise<void>; <T>(ms: number, value: T): Promise<T> }
constructor(
@ -19,7 +20,8 @@ export default class JaxRequest {
config: JaxConfig,
endpoint: string,
limiter: RiotRateLimiter,
cacheTime: number
cacheTime: number,
riotApiPath = `lol`
) {
this.region = region
this.config = config
@ -27,12 +29,13 @@ export default class JaxRequest {
this.limiter = limiter
this.cacheTime = cacheTime
this.retries = config.requestOptions.retriesBeforeAbort
this.riotApiPath = riotApiPath
this.sleep = promisify(setTimeout)
}
public async execute() {
const url = `https://${this.region}.api.riotgames.com/lol/${this.endpoint}`
const url = `https://${this.region}.api.riotgames.com/${this.riotApiPath}/${this.endpoint}`
// Redis cache
if (this.cacheTime > 0) {

View file

@ -63,6 +63,14 @@ class SummonerService {
return account
}
public async getRiotAccountByName(name: string, tagline: string, region: string) {
return await Jax.Summoner.puuidFromRiotTag(name, tagline, region)
}
public async getSummonerByPuuid(puuid: string, region: string) {
return await Jax.Summoner.summonerPuuid(puuid, region)
}
/**
* Return the full list of old and actual summoner names
* @param account of the summoner

View file

@ -24,7 +24,7 @@ export default class SummonerBasicValidator {
* ```
*/
public schema = schema.create({
summoner: schema.string({}, [rules.regex(/^[0-9\p{L} _\.]+$/u)]),
summoner: schema.string({}, [rules.regex(/^[0-9\p{L} _\.-]+$/u)]),
region: schema.string(),
})