Doble/LeagueStats
1
0
Fork 0
mirror of https://github.com/vkaelin/LeagueStats.git synced 2026-03-25 12:57:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: better error logging in JaxRequest

Browse source
This commit is contained in:
Valentin Kaelin 2020-06-13 23:24:08 +02:00
parent 62e4c91e7f
commit e0adc777e0
2 changed files with 17 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
server/app/Services/Jax/src/JaxRequest.js
View file

@ -1,4 +1,5 @@
const { promisify } = require('util')
const Logger = use('Logger')
const Redis = use('Redis')
class JaxRequest {
@ -38,7 +39,14 @@ class JaxRequest {
} catch ({ statusCode, ...rest }) {
this.retries--
if (statusCode !== 503 && statusCode !== 500) return
if (statusCode !== 503 && statusCode !== 500) {
// Don't log 404 when summoner isn't playing
if (!this.endpoint.includes('spectator')) {
Logger.transport('file').error(`JaxRequest Error ${statusCode} : `, rest)
}
return
}
console.log('====================================')
console.log(statusCode)

13
server/app/Services/MatchService.js
View file

@ -68,11 +68,9 @@ class MatchService {
// Update Summoner's MatchList
for (const match of matchList.reverse()) {
if (!summonerDB.matchList.some(m => m.gameId === match.gameId)) {
Logger.transport('file').info(`Match ${match.gameId} has been added to ${account.name}'s MatchList.`)
summonerDB.matchList.unshift(match)
}
}
Logger.transport('file').info(`Summoner ${account.name} has been updated.`)
}
// First search of the Summoner
else {
@ -83,7 +81,6 @@ class MatchService {
})
// Create Summoner's MatchList in Database
summonerDB.matchList = matchList
Logger.transport('file').info(`Summoner ${account.name} has been created.`)
}
console.timeEnd('matchList')
}
@ -116,16 +113,22 @@ class MatchService {
const ctx = {
account,
}
// Try to see why matches are sometimes undefined
matchesFromApi.filter(m => {
if(m === undefined) {
Logger.transport('file').info('Match undefined', matchesToGetFromRiot)
}
})
// Transform raw matches data
await BasicMatchTransformer.transform(matchesFromApi, ctx)
Logger.transport('file').info(matchesFromApi)
/* Save all matches from Riot Api in db */
for (const match of matchesFromApi) {
await summonerDB.matches().create(match)
match.newMatch = true
}
console.log('matches saved in db')
matchesDetails = [...matchesDetails, ...matchesFromApi]
}