From fe60e85b6a6b2811e4ce5c5daf4a59882028b20a Mon Sep 17 00:00:00 2001
From: Valentin Kaelin <kalanehd@gmail.com>
Date: Wed, 1 Jan 2020 16:39:54 +0100
Subject: [PATCH] style: remove old comments and change method names

---
 .../Summoner/Overview/SummonerChampions.vue     |  2 +-
 .../Summoner/Overview/SummonerStats.vue         |  2 +-
 client/src/layouts/Default.vue                  |  5 ++---
 client/src/store/modules/summoner.js            | 17 +++++------------
 client/src/views/Summoner.vue                   |  3 +--
 client/src/views/SummonerChampions.vue          |  7 +++----
 .../app/Controllers/Http/SummonerController.js  |  1 -
 7 files changed, 13 insertions(+), 24 deletions(-)

diff --git a/client/src/components/Summoner/Overview/SummonerChampions.vue b/client/src/components/Summoner/Overview/SummonerChampions.vue
index ef03d38..e089dd3 100644
--- a/client/src/components/Summoner/Overview/SummonerChampions.vue
+++ b/client/src/components/Summoner/Overview/SummonerChampions.vue
@@ -19,7 +19,7 @@
             <div class="px-2 text-white text-center text-sm select-none">
               <div>Stats based on</div>
               <div>
-                <span class="text-teal-400 font-bold">{{ stats.global.count }}</span> matches
+                <span class="text-teal-400 font-bold">{{ stats.global ? stats.global.count : 0 }}</span> matches
               </div>
               <div class="mt-2 leading-tight text-xs text-blue-100 font-normal italic">
                 Load more matches
diff --git a/client/src/components/Summoner/Overview/SummonerStats.vue b/client/src/components/Summoner/Overview/SummonerStats.vue
index 8815252..aca0e9e 100644
--- a/client/src/components/Summoner/Overview/SummonerStats.vue
+++ b/client/src/components/Summoner/Overview/SummonerStats.vue
@@ -1,5 +1,5 @@
 <template>
-  <div class="mt-4 bg-blue-800 rounded-lg">
+  <div v-if="stats.global" class="mt-4 bg-blue-800 rounded-lg">
     <div class="relative heading flex justify-center py-4 rounded-t-lg text-blue-200">
       <svg class="w-6 h-6">
         <use xlink:href="#graph" />
diff --git a/client/src/layouts/Default.vue b/client/src/layouts/Default.vue
index 586311c..b322a9b 100644
--- a/client/src/layouts/Default.vue
+++ b/client/src/layouts/Default.vue
@@ -124,18 +124,17 @@ export default {
       return `${this.summoner}|${this.region}`
     },
     tabTransition() {
-      return this.summonerFound ? 'tab' : 'none'
+      return this.summonerFound && this.overviewLoaded ? 'tab' : 'none'
     },
     ...mapState({
       basic: state => state.summoner.basic
     }),
-    ...mapGetters('summoner', ['playing', 'summonerFound', 'summonerNotFound', 'summonerLoading'])
+    ...mapGetters('summoner', ['playing', 'overviewLoaded', 'summonerFound', 'summonerNotFound', 'summonerLoading'])
   },
 
   watch: {
     uri() {
       console.log('route changed')
-      // console.log(this.$router.currentRoute)
       this.updateCurrentRegion(this.region)
       this.apiCall()
     }
diff --git a/client/src/store/modules/summoner.js b/client/src/store/modules/summoner.js
index d8450b4..bddbcaa 100644
--- a/client/src/store/modules/summoner.js
+++ b/client/src/store/modules/summoner.js
@@ -69,7 +69,7 @@ export const actions = {
     try {
       const resp = await axios(({ url: 'summoner-basic', data: { summoner, region }, method: 'POST' }))
       if (resp.data) {
-        console.log('--- SUMMONER INFOS ---')
+        console.log('---SUMMONER INFOS---')
         console.log(resp.data)
         const infos = createBasicSummonerData(resp.data)
         commit('SUMMONER_FOUND', infos)
@@ -87,10 +87,9 @@ export const actions = {
       console.log(error)
     }
   },
-  async championStats({ commit }, queue = null) {
+  async championsRequest({ commit }, queue = null) {
     const resp = await axios(({ url: 'summoner-champions', data: { puuid: state.basic.account.puuid, queue: queue }, method: 'POST' })).catch(() => { })
-    console.log('CHAMPIONS STATS')
-    console.log('queue: ', queue)
+    console.log('---CHAMPIONS---')
     console.log(resp.data)
 
     commit('CHAMPIONS_FOUND', { champions: resp.data })
@@ -102,20 +101,14 @@ export const actions = {
     const gameIds = state.basic.matchList.slice(state.overview.matchIndex, state.overview.matchIndex + 10).map(({ gameId }) => gameId)
 
     const resp = await axios(({ url: 'match', data: { account, gameIds }, method: 'POST' })).catch(() => { })
-    console.log('--- MATCHES INFOS ---')
+    console.log('---MATCHES INFOS---')
     console.log(resp.data)
     const newMatches = createMatchData(resp.data.matches)
     commit('MATCHES_FOUND', { newMatches, stats: resp.data.stats })
   },
   async overviewRequest({ commit }) {
     const resp = await axios(({ url: 'summoner-overview', data: { account: state.basic.account }, method: 'POST' })).catch(() => { })
-    // setTimeout(() => {
-    //   console.log('OVERVIEW')
-    //   console.log(resp.data)
-    //   resp.data.matches = createMatchData(resp.data.matchesDetails)
-    //   commit('OVERVIEW_FOUND', resp.data)
-    // }, 2000)
-    console.log('OVERVIEW')
+    console.log('---OVERVIEW---')
     console.log(resp.data)
     resp.data.matches = createMatchData(resp.data.matchesDetails)
     commit('OVERVIEW_FOUND', resp.data)
diff --git a/client/src/views/Summoner.vue b/client/src/views/Summoner.vue
index a073c4a..bdc20bc 100644
--- a/client/src/views/Summoner.vue
+++ b/client/src/views/Summoner.vue
@@ -5,7 +5,7 @@
       <SummonerStats />
       <SummonerMates />
     </div>
-    <div class="w-9/12">
+    <div v-if="overview.matches.length" class="w-9/12">
       <ul>
         <Match
           v-for="(match, index) in overview.matches"
@@ -318,7 +318,6 @@ export default {
   methods: {
     fetchData() {
       if (!this.overviewLoaded && this.summonerFound) {
-        console.log('FETCHING OVERVIEW')
         this.overviewRequest()
       }
     },
diff --git a/client/src/views/SummonerChampions.vue b/client/src/views/SummonerChampions.vue
index ab253e1..360f1cb 100644
--- a/client/src/views/SummonerChampions.vue
+++ b/client/src/views/SummonerChampions.vue
@@ -65,19 +65,18 @@ export default {
   methods: {
     fetchData() {
       if (!this.championsLoaded && this.summonerFound) {
-        console.log('FETCHING CHAMPIONS')
-        this.championStats()
+        this.championsRequest()
       }
     },
     filterByQueue(queue) {
       queue = Number(queue)
       queue = queue === -1 ? null : queue
-      this.championStats(queue)
+      this.championsRequest(queue)
     },
     updateSearch(search) {
       this.searchChampions = search
     },
-    ...mapActions('summoner', ['championStats']),
+    ...mapActions('summoner', ['championsRequest']),
   }
 }
 </script>
diff --git a/server/app/Controllers/Http/SummonerController.js b/server/app/Controllers/Http/SummonerController.js
index 5ef29ef..b5003a5 100644
--- a/server/app/Controllers/Http/SummonerController.js
+++ b/server/app/Controllers/Http/SummonerController.js
@@ -68,7 +68,6 @@ class SummonerController {
   async overview({ request, response }) {
     console.time('overview')
     const account = request.input('account')
-    console.log(account)
     const finalJSON = {}
 
     // Summoner in DB